WiX: Remove PackageModelSyntax component
#453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is the last issue that prevents swiftlang/swift-package-manager#9016 from landing. |
xedin
changed the title
PackageModelSyntax dependencyPackageModelSyntax component
`PackageModelSyntax` module is about to get removed from Swift Package Manager because the functionality has been moved to swift-syntax. Sourcekit-LSP was the only external user of the library which is no longer the case.
xedin
force-pushed
the
remove-package-model-syntax-wix
branch
from
165d559 to
899f950
Compare
Member
|
Please link the cross repo build that built the toolchain - this is probably a good idea to smoke test. |
Contributor
Author
Contributor
Author
|
This was a successful build with this change + a complete removal of the PackageModuleSyntax from swiftpm. |
etcwilde
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageModelSyntaxmodule is about to get removed from Swift Package Manager because the functionality has been moved to swift-syntax. Sourcekit-LSP was the only external user of the library which is no longer the case.