WiX: repair the Windows SDK packaging #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have brotli as a dependency and must distribute the static libraries as part of the static SDK.
|
CC: @zhenchaoli This is part of the change, we need to do the same for android, but I will do that as a separate change. |
etcwilde
reviewed
Oct 15, 2025
etcwilde
approved these changes
Oct 15, 2025
|
We do indeed; I need to figure out how to fix the android packaging, I think that there are other ways that it is currently broken :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have brotli as a dependency and must distribute the static libraries as part of the static SDK.