Skip to content

fix mistake in how filtering applied to wrap java #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+13 −3
Merged

fix mistake in how filtering applied to wrap java #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Sources/SwiftJavaTool/Commands/WrapJavaCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,19 @@ extension SwiftJava.WrapJavaCommand {

private func shouldImportJavaClass(_ javaClassName: String, config: Configuration) -> Bool {
// If we have an inclusive filter, import only types from it
for include in config.filterInclude ?? [] {
guard javaClassName.starts(with: include) else {
log.info("Skip Java type: \(javaClassName) (does not match include filter: \(include))")
if let includes = config.filterInclude, !includes.isEmpty {
let anyIncludeFilterMatched = includes.contains { include in
if javaClassName.starts(with: include) {
// TODO: lower to trace level
log.info("Skip Java type: \(javaClassName) (does not match any include filter)")
return true
}

return false
}

guard anyIncludeFilterMatched else {
log.info("Skip Java type: \(javaClassName) (does not match any include filter)")
return false
}
}
Expand Down
Loading