Skip to content

Conversation

@GREENOVER
Copy link
Contributor

Summary

Found the missing code convention of the array in the MarkupTest code.
So, add it to this.

Checklist

  • Added tests
  • Ran the ./bin/test script and it succeeded

@Monsteel
Copy link

Cool😃
I agree this PR's suggestion!🙌

@franklinsch franklinsch self-requested a review October 19, 2021 17:41
Copy link
Contributor

@franklinsch franklinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this file is generally using trailing commas for the last elements of array—thanks for spotting this and opening a PR! If we do want to be consistent with the trailing commas here, it looks like some other places are missing it, so we should update those as well I'd say.

@GREENOVER
Copy link
Contributor Author

@franklinsch
Thank you👍🏻
I think so, too.
Currently, other files have not yet found the same part as the this PR.
If it is found after an overall inspection, I will additionally commit it :)

@GREENOVER
Copy link
Contributor Author

@franklinsch
I reviewed all the files to find and add two parts that did not fit the array convention.
I hope it will be reflected for the perfection of the code.

@GREENOVER GREENOVER requested a review from franklinsch October 20, 2021 06:08
@franklinsch
Copy link
Contributor

@swift-ci test

@franklinsch
Copy link
Contributor

@swift-ci please test Linux

@franklinsch
Copy link
Contributor

@swift-ci please test Linux

@franklinsch
Copy link
Contributor

@swift-ci please test macOS

@franklinsch franklinsch merged commit b73b9d8 into swiftlang:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants