Handle reduce motion #991
Merged
Handle reduce motion #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobucchi
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
kaishin,
shahmishal and
timsneath
as code owners
jesseaborden
requested changes
May 29, 2025
| swoop.ctx = canvasData.ctx | ||
| swoop.pathInstance = canvasData.pathInstance | ||
| }) | ||
| swoop.image = swoopImages[i]; |
Contributor
There was a problem hiding this comment.
Looks like formatter missed the ";"
Member
Author
There was a problem hiding this comment.
I am planning to make a PR to run the formatter later. I didn't want to run it because it is going to affect other files outside this PR
jesseaborden
approved these changes
May 29, 2025
Contributor
jesseaborden
left a comment
jesseaborden
left a comment
There was a problem hiding this comment.
Little formatting note, but otherwise looking good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If reduce motion is enabled, we should show the graphics at their final state.
Result:
If reduce motion is enabled, the animation will now show