Allow FileSystem.exists to follow symlinks or not #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
aciidgh
reviewed
Nov 30, 2017
| let target = path.appending(component: "target") | ||
| try fs.writeFileContents(target, bytes: "source") | ||
|
|
||
| // source and target exist |
Contributor
There was a problem hiding this comment.
Nit: Capitalize and punctuation.
// Source nad target exists.
aciidgh
reviewed
Nov 30, 2017
| XCTAssertEqual(fs.exists(source, followSymlink: true), true) | ||
| XCTAssertEqual(fs.exists(source, followSymlink: false), true) | ||
|
|
||
| // source only exists |
Contributor
There was a problem hiding this comment.
Nit: Capitalize and punctuation.
aciidgh
reviewed
Nov 30, 2017
| XCTAssertEqual(fs.exists(source, followSymlink: true), false) | ||
| XCTAssertEqual(fs.exists(source, followSymlink: false), true) | ||
|
|
||
| // none exist |
Contributor
There was a problem hiding this comment.
Nit: Capitalize and punctuation.
aciidgh
approved these changes
Nov 30, 2017
hartbit
force-pushed
the
filesystem-exists-symlink
branch
from
02369af to
95bd923
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.