Incorporate SE-0292 feedback into RegistryDraft (Second Review) #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
approved these changes
May 13, 2021
|
@mattt is this ready to be merged? |
|
@tomerd My plan was to coordinate this with swiftlang/swift-evolution#1319, so that they get merged together. Was there anything else you'd like to add or change to either of these? Or can we go ahead and merge them? |
mattt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes to the draft registry specification in response to feedback for SE-0292.
urlfield optional in release objects, as discussed in Incorporate feedback from 2nd review of SE-0292 swift-evolution#1319 (comment)