Add .netrc to default .gitignore #3511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
tomerd
approved these changes
May 26, 2021
|
@swift-ci please smoke test |
neonichu
approved these changes
May 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
.netrcto the.gitignorefile in the new project template.Motivation:
As discussed in swiftlang/swift-evolution#1319, a user may inadvertently expose credentials by checking in their project's
.netrcfile. Adding this entry to the.gitignorefile in the new project template significantly minimizes the possibility of the user leaking credentials in the future.Modifications:
+ .netrcResult:
After this change, all future projects created by running
swift package initwill default to ignoring.netrcfiles.Existing packages will be unaffected.