Skip to content

Conversation

@mattt
Copy link
Contributor

@mattt mattt commented Jul 20, 2021

This PR makes the changes to the registry service specification described in swiftlang/swift-evolution#1410

@neonichu
Copy link
Contributor

@swift-ci please smoke test

Copy link
Contributor

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apple/swift-package-manager/pull/3624/files#diff-1dfed3389cc482cc6446784dd9e800e5dbab6d62356bfac3010cc1382151c4bdR602-R603

A client MAY send a GET request for a URI matching the expression /{scope}/{name}/{version}

I suggest changing the URI to /{scope}/{name}/{version}.zip since .zip is required.

@tomerd
Copy link
Contributor

tomerd commented Jul 22, 2021

@mattt @yim-lee should we wait before merging these PRs to see if there are further amendments we need to make and then do all in one go?

@mattt mattt force-pushed the mattt-amend-se-0292 branch from 751f462 to aa5e65b Compare July 22, 2021 17:17
@mattt
Copy link
Contributor Author

mattt commented Jul 29, 2021

@swift-ci please smoke test

mattt added 2 commits August 3, 2021 05:38
…s-version attribute

Update regular expression pattern for version-specific manifest filenames
@mattt mattt force-pushed the mattt-amend-se-0292 branch from 5afa6b3 to 362099a Compare August 7, 2021 13:17
@tomerd tomerd added the WIP Work in progress label Aug 19, 2021
@mattt

This comment has been minimized.

@mattt mattt added ready Author believes the PR is ready to be merged & any feedback has been addressed and removed WIP Work in progress labels Aug 24, 2021
@tomerd
Copy link
Contributor

tomerd commented Aug 25, 2021

@yim-lee @mattt do you feel this is ready to push forward with? We would probably need a short amendment review with the community

@mattt
Copy link
Contributor Author

mattt commented Aug 25, 2021

@tomerd Yes, I think this is ready to go. Feel free to proceed as you see fit.

@tomerd
Copy link
Contributor

tomerd commented Aug 27, 2021

@mattt I believe we would need to run a short amendment review (eg https://forums.swift.org/t/amendment-se-0296-allow-overloads-that-differ-only-in-async/49808). I will make this a topic for next swift core team meeting

@tomerd
Copy link
Contributor

tomerd commented Sep 1, 2021

@mattt @yim-lee amendment review: https://forums.swift.org/t/amendment-se-0292-package-registry-service/51663

Co-authored-by: Yim Lee <yim_lee@apple.com>
@tomerd
Copy link
Contributor

tomerd commented Sep 15, 2021

hi @mattt, with the amendment accepted I think we can now merge this. would you like to resolve the remaining conflicts, so I can take care of that?

@mattt
Copy link
Contributor Author

mattt commented Sep 15, 2021

@swift-ci Please smoke test

@mattt
Copy link
Contributor Author

mattt commented Sep 15, 2021

@tomerd Sure thing. That should be all of the pending feedback. Let me know if there's anything else you'd like me to do with this PR.

@tomerd tomerd merged commit 7e53f24 into main Sep 15, 2021
@mattt mattt deleted the mattt-amend-se-0292 branch September 15, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Author believes the PR is ready to be merged & any feedback has been addressed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants