-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update Registry documentation according to SE-0292 amendment #3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A client MAY send a
GETrequest for a URI matching the expression/{scope}/{name}/{version}
I suggest changing the URI to /{scope}/{name}/{version}.zip since .zip is required.
751f462 to
aa5e65b
Compare
|
@swift-ci please smoke test |
…s-version attribute Update regular expression pattern for version-specific manifest filenames
5afa6b3 to
362099a
Compare
This comment has been minimized.
This comment has been minimized.
|
@tomerd Yes, I think this is ready to go. Feel free to proceed as you see fit. |
|
@mattt I believe we would need to run a short amendment review (eg https://forums.swift.org/t/amendment-se-0296-allow-overloads-that-differ-only-in-async/49808). I will make this a topic for next swift core team meeting |
Co-authored-by: Yim Lee <yim_lee@apple.com>
|
hi @mattt, with the amendment accepted I think we can now merge this. would you like to resolve the remaining conflicts, so I can take care of that? |
|
@swift-ci Please smoke test |
|
@tomerd Sure thing. That should be all of the pending feedback. Let me know if there's anything else you'd like me to do with this PR. |
This PR makes the changes to the registry service specification described in swiftlang/swift-evolution#1410