PackageDescription: repair the build after #3635 #3646
Conversation
The C imports are important, particularly on Windows, where `HANDLE` is not available without the platform SDK (`WinSDK` is roughly synonymous to `Darwin`).
compnerd
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
There was a problem hiding this comment.
LGTM. FWIW, in the next week or two I also plan to clean up the package manifest output so we can get rid of some of these platform-specifics (at least the writing out of the JSON on a separate pipe) by reusing some of the code that's used for package plugins. But of course this should be put back meanwhile; I only mention it to point out that we should be able to get rid of some of this again soonish.
|
@swift-ci please smoke test |
|
Started the smoke test, which is what's required for main. |
|
@abertelrud cool, though, please do test on windows before merging that. We really do need to get CI here (CC: @tomerd) |
|
@compnerd @shahmishal I would love to be able to test Windows in CI, what need to be done to get there? |
4 participants
The C imports are important, particularly on Windows, where
HANDLEisnot available without the platform SDK (
WinSDKis roughly synonymousto
Darwin).[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]