bootstrap: generalize check for cross-compilation on Darwin #5755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so that the build with swiftpm can start. This will allow to build a Swift toolchain on Apple Silicon Addresses rdar://99484030
edymtt
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
I think we need to keep checking |
finagolfin
reviewed
Sep 3, 2022
Contributor
Author
|
@swift-ci please smoke test |
finagolfin
approved these changes
Sep 5, 2022
|
We definitely need this fix to build the toolchain on M1, I ended up with the same fix locally. It's good to see the fix finally landing.👍 |
tomerd
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that the build with swiftpm can start.
This will allow to build a Swift toolchain on Apple Silicon
Addresses rdar://99484030
Motivation:
We are ironing out the current issues we are having when building a toolchain on Apple Silicon, and after #5754 we are now hitting
Modifications:
Amend a check so not to assume any particular architecture when assessing if we are cross compiling on Darwin.
Result:
We should be able to build swiftpm as part of a Swift toolchain on Apple Silicon