Do not add rpath to swift-testing for CLT or custom toolchains #8295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
MaxDesiatov,
bkhouri,
bripeticca,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci please test |
dschaefer2
approved these changes
Feb 14, 2025
|
@swift-ci please test macOS platform |
This was added so that test binaries could find swift-testing, but we should insert those paths into `DYLD_*_PATH` rather than add to the rpath. The current behavior adds an absolute rpath to *all* binaries, not even just test binaries.
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
jakepetroules
approved these changes
Feb 17, 2025
|
@swift-ci please test Windows platform |
plemarquand
approved these changes
Feb 18, 2025
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Apr 24, 2025
A change in SwiftPM removed the rpath that pointed to `usr/lib/swift/macosx/testing` (swiftlang/swift-package-manager#8295). Consequently when debugging tests in VS Code `libTesting.dylib` could not be found and the tests would not start. This is only happening in nightly toolchains that contain the SwiftPM change noted above. Fix this by adding the search path to the DYLD_LIBRARY_PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added so that test binaries could find swift-testing, but we should insert those paths into
DYLD_*_PATHrather than add to the rpath. The current behavior adds an absolute rpath to all binaries, not even just test binaries.