Fix unhandled platform condition w/ freeBSDFilters for PIFBuilder
#8359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbute
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
Note: the only files changed are : Sources/SwiftBuildSupport/PIFBuilder.swift |
|
Can you pull the latest main, rebase, and force push, please? This is difficult to review when it's mixed in with a bunch of other changes. |
bkhouri
reviewed
Mar 11, 2025
johnbute
force-pushed
the
freeBSD-platform-filter-case
branch
from
ddd93a4 to
fcd2d09
Compare
|
@swift-ci test |
|
@swift-ci test windows |
jakepetroules
approved these changes
Mar 12, 2025
MaxDesiatov
changed the title
freeBSDFilters for PIFBuilder
MaxDesiatov
changed the title
freeBSDFilters for PIFBuilder freeBSDFilters for PIFBuilder
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled case where SwiftBuild is run on a freeBSD OS.
Motivation:
Currently, when using the new build system, you come across the following fatal error when building on a freeBSD OS:
Fatal error: Unhandled platform condition: Platform (name: "free bsd", oldestSupportedVersion: PackageModel.PlatformVersion(version: 0.0.0))
Modifications:
All I have done is, similar to Sources/XCBuildSupport/PIFBuilder, I added the case and handled it just like XCBuild's PIFBuilder does.
Result:
After changes, no more fatal error occurs and building proceeds as it should.