Mark completion callbacks as Sendable #8712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
shawnhyam
as code owners
Many of the completion callbacks used in the legacy sync versions of async functions were not marked as Sendable. This produced a warning when they were provided to `DispatchQueue.asyncResult`, which expects a Sendable callback.
plemarquand
force-pushed
the
sendable-async-result-callbacks
branch
from
ccf7ccd to
bb5d0be
Compare
jakepetroules
approved these changes
May 22, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci test macos |
Contributor
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the completion callbacks used in the legacy sync versions of async functions were not marked as Sendable. This produced a warning when they were provided to
DispatchQueue.asyncResult, which expects a Sendable callback.