Make lazy properties in UserToolchain thread safe #9356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
rconnell9
as code owners
plemarquand
force-pushed
the
thread-safe-lazy-usertoolchain
branch
2 times, most recently
from
753bcfc to
274f115
Compare
Contributor
Author
|
@swift-ci please test |
jakepetroules
requested changes
Nov 10, 2025
Contributor
Author
|
@swift-ci please test |
jakepetroules
approved these changes
Nov 11, 2025
`runtimeLibraryPaths`, `swiftCompilerVersion` and `targetInfo` were all marked as lazy on the UserToolchain class which could lead to race conditions if callers on multiple threads attempted to initialize them simultaneously. Use an `NSRecursiveLock` to guard access while initialization occurs, preventing crashes.
plemarquand
force-pushed
the
thread-safe-lazy-usertoolchain
branch
from
6c9b43e to
b3f0ac6
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtimeLibraryPaths,swiftCompilerVersionandtargetInfowere all marked as lazy on the UserToolchain class which could lead to race conditions if callers on multiple threads attempted to initialize them simultaneously.Use a
ThreadSafeBoxto guard access while initialization occurs, preventing crashes.