Skip to content

Enable newly passing tests after fixing Swift Build response file format issues #9382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Enable newly passing tests after fixing Swift Build response file format issues #9382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/FunctionalTests/CFamilyTargetTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ fileprivate func expectDirectoryContainsFile(
)
struct CFamilyTargetTestCase {
@Test(
.issue("https://github.com/swiftlang/swift-build/issues/333", relationship: .defect),
.IssueWindowsLongPath,
.tags(
.Feature.Command.Build,
.Feature.SpecialCharacters,
Expand All @@ -73,7 +73,7 @@ struct CFamilyTargetTestCase {
}
}
} when: {
data.buildSystem == .swiftbuild
ProcessInfo.hostOperatingSystem == .windows && data.buildSystem == .swiftbuild
}
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/FunctionalTests/TestDiscoveryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ struct TestDiscoveryTests {
#expect(stdout.contains("Executed 1 test"))
}
} when: {
buildSystem == .swiftbuild && [.windows, .macOS].contains(ProcessInfo.hostOperatingSystem)
buildSystem == .swiftbuild && [.windows].contains(ProcessInfo.hostOperatingSystem)
}
}

Expand Down