[GH:#9304] Explicit source file declaration in Target's sources causes a performance degradation in TargetSourcesBuilder #9385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces causes a performance degradation in TargetSourcesBuilder
rconnell9
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
plemarquand
as code owners
Contributor
Author
|
@swift-ci test |
owenv
approved these changes
Nov 17, 2025
jakepetroules
approved these changes
Nov 17, 2025
Contributor
Author
|
@swift-ci test windows |
Contributor
|
@swift-ci please test windows |
Contributor
Author
|
@swift-ci test windows self hosted |
1 similar comment
Contributor
Author
|
@swift-ci test windows self hosted |
Contributor
|
@swift-ci test self hosted windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid expensive string array operations when performing target source evaluation.
Local timings for target source evaluation of protoc before and after:
Before: 'swift-protobuf': TargetSourcesBuilder.run() for target 'protoc' took 11.544s
After: 'swift-protobuf': TargetSourcesBuilder.run() for target 'protoc' took 0.190s
CPU cycles for full build of swift-protobuf:
Before: 33.43 G
After: 5.72 G
Motivation:
Fixes: #9304