Skip to content

Fix for linking tests with swiftbuild on windows #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daveinglis merged 1 commit into from
Dec 5, 2025
Merged

Fix for linking tests with swiftbuild on windows #9405

daveinglis merged 1 commit into from
Dec 5, 2025

Conversation

@daveinglis
Copy link
Contributor

@daveinglis daveinglis commented Nov 20, 2025

  • need library search path to ExecutableModules for windows

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 20, 2025

@swift-ci test

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 20, 2025

@swift-ci test linux

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 20, 2025

@swift-ci test macOS linux

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 20, 2025

@swift-ci test linux

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 20, 2025

@swift-ci test macos

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 21, 2025

@swift-ci test windows

bkhouri
bkhouri requested changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@bkhouri bkhouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an automated tests to ensure we don't regress this behaviour?

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 21, 2025

@swift-ci test

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 24, 2025

@swift-ci test windows

@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 1, 2025

@swift-ci test window self hosted

@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 1, 2025

@swift-ci test

1 similar comment
@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 3, 2025

@swift-ci test

@daveinglis
Fix for linking tests with swiftbuild on windows
f127fd0 
- need library search path to ExecutableModules for windows
@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 5, 2025

@swift-ci test

@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 5, 2025

@swift-ci test windows

1 similar comment
@daveinglis
Copy link
Contributor Author

daveinglis commented Dec 5, 2025

@swift-ci test windows

@daveinglis daveinglis merged commit cb587d2 into swiftlang:main Dec 5, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@bkhouri bkhouri bkhouri approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daveinglis @jakepetroules @bkhouri