Set explicit file types in PIF for binary artifacts #9479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Dec 8, 2025
| case .unknown: | ||
| fileTypeIdentifier = nil | ||
| } | ||
| return FileReference(id: id, path: (binaryModule.artifactPath.pathString), fileType: fileTypeIdentifier) |
Contributor
There was a problem hiding this comment.
nit: extraneous parens
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test self hosted |
1 similar comment
Contributor
Author
|
@swift-ci test self hosted |
Contributor
Author
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that even if an artifact bundle is downloaded and unpacked without a file extension, the underlying build system can identify it correctly.
Closes #9471
Depends on swiftlang/swift-build#962
I wasn't able to add a test for this because I can only reproduce it with remote packages