Skip to content

Conversation

@slowy07
Copy link
Contributor

@slowy07 slowy07 commented Aug 3, 2021

Pull Request Description

fix logical should 'not in' and fixed function must one space

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • MIT
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.
@swift-ci Please test source compatibility

@shahmishal
Copy link
Member

@swift-ci test

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slowy07
Copy link
Contributor Author

slowy07 commented Aug 14, 2021

thank you sir @shahmishal

@shahmishal shahmishal merged commit cea91b8 into swiftlang:main Sep 7, 2021
@slowy07 slowy07 deleted the minor-fixing branch January 29, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants