Skip to content

Conversation

@freak4pc
Copy link
Contributor

Pull Request Description

Resolve swiftlang/swift#57007,
Update the RxSwift dependency to v6.5.0 and add RxRelay

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@freak4pc
Copy link
Contributor Author

Hey @justice-adams-apple - I've opened this mainly to test against your CI, was having some issues testing locally. I'll keep working until resolved :)

@freak4pc
Copy link
Contributor Author

@justice-adams-apple should be good to go. I tested locally and it seems fine now :)
Let me know if I can help with anything else, and sorry for the delay on this.

@justice-adams-apple
Copy link
Collaborator

@swift-ci test

@freak4pc
Copy link
Contributor Author

🥳

image

@justice-adams-apple justice-adams-apple merged commit 09d1165 into swiftlang:main Sep 29, 2022
@freak4pc freak4pc deleted the rxswift-6.5-compat branch September 29, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SR-14655] [Source Compat] RxTest - several errors related to XCTest usage

2 participants