Skip to content

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented May 2, 2024

  • Explanation: In some build scenarios compilers get confused if a file named errno.h includes errno.h, even if it’s intended to be from a different directory. Renaming the files in swift-syntax works around that issue.
  • Scope: File names of an internal module
  • Risk: Low, just renames files in an internal module that are only exposed via a module map
  • Testing: Verified that swift-syntax still builds
  • Issue: n/a
  • Reviewer: @rintaro @bnbarham

…tax_stdio.h`

In some build scenarios compilers get confused if a file named `errno.h` includes `errno.h`, even if it’s intended to be from a different directory. Renaming the files in swift-syntax works around that issue.
@ahoppen ahoppen requested a review from bnbarham as a code owner May 2, 2024 15:31
@ahoppen ahoppen requested a review from rintaro May 2, 2024 15:31
@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2024

@swift-ci Please test

@ahoppen ahoppen changed the title Rename errno.h and stdio.h to swiftsyntax_errno.h and `swiftsyn… [6.0] Rename errno.h and stdio.h to swiftsyntax_errno.h and swiftsyntax_stdio.h May 2, 2024
@ahoppen ahoppen merged commit 9e802f9 into swiftlang:release/6.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants