[DNM] Support box-drawing-based blocks #2928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s a social media post circulating where `#define` is used to write blocks using box-drawing characters in C code. Swift macros aren’t suitable for that kind of thing, but I wanted to see how difficult it would be to implement, just for funsies.
This is—and I cannot believe I am about to write this sentence—perhaps not the way we would actually want to implement box-drawing-based blocks, as it works by treating most of the characters as trivia and only assigning a semantic meaning to a few corners. That means it doesn’t actually enforce the validity of the box shapes.
Nor is this—and I cannot believe I am about to write *this* sentence, either—a production-quality implementation of box-drawing-based blocks. There’s a lot I haven’t tested, the diagnostics are probably a mess, and there are a number of places where I suspect I made changes that would cost us some speed.
However, it’s certainly a fun little hack:
```
assertParse(
#"""
╔═════════════ func fizzBuzz() ═════════════╗
║ ╔═══════════ for i in 0..<100 ══════════╗ ║
║ ║ ╔═════ if i.isMultiple(of: 15) ═════╗ ║ ║
║ ║ ║ print("fizzbuzz ") ║ ║ ║
║ ║ ╠═══ else if i.isMultiple(of: 3) ═══╣ ║ ║
║ ║ ║ print("fizz ") ║ ║ ║
║ ║ ╠═══ else if i.isMultiple(of: 5) ═══╣ ║ ║
║ ║ ║ print("buzz ") ║ ║ ║
║ ║ ╠══════════════ else ═══════════════╣ ║ ║
║ ║ ║ print("\(i) ") ║ ║ ║
║ ║ ╚═══════════════════════════════════╝ ║ ║
║ ╚═══════════════════════════════════════╝ ║
╚═══════════════════════════════════════════╝
"""#
)
```
Contributor
|
SE-NNNN: Allow control flow using arrows 😄 |
|
|
This involves, among other things, introducing new SyntaxNodeWithBody parameters and methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s a social media post circulating where
#defineis used to write blocks using box-drawing characters in C code. Swift macros aren’t suitable for that kind of thing, but I wanted to see how difficult it would be to implement, just for funsies.This is—and I cannot believe I am about to write this sentence—perhaps not the way we would actually want to implement box-drawing-based blocks, as it works by treating most of the characters as trivia and only assigning a semantic meaning to a few corner characters that happen to fall into the same positions as braces. That means it doesn’t actually enforce the validity of the box shapes.
Nor is this—and I cannot believe I am about to write this sentence, either—a production-quality implementation of box-drawing-based blocks. There’s a lot I haven’t tested, the diagnostics are probably a mess, there’s no formatter support (which would actually be a super cool addition), and there are a number of places where I suspect I made changes that would cost us some speed.
However, it’s certainly a fun little hack: