Adopt @section and @used.
#1408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adopts the `@section` and `@used` attributes now available in the Swift 6.3 toolchain. These attributes replace the experimental `@_section` and `@_used` attributes verbatim and they are always enabled (so no need to check `hasFeature(SymbolLinkageMarkers)`.) Because these attributes are only available with the Swift 6.3 toolchain, we do not use them when building with Swift 6.2. Instead, if you build with Swift 6.2 you continue to use the "legacy" test discovery mechanism based on type metadata emission. The "legacy" mechanism will be removed in a future update. Resolves #1371.
grynspan
added
performance
This reverts commit c3efd87.
Contributor
Author
|
Blocked by swiftlang/swift#85411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the
@sectionand@usedattributes now available in the Swift 6.3 toolchain. These attributes replace the experimental@_sectionand@_usedattributes verbatim and they are always enabled (so no need to checkhasFeature(SymbolLinkageMarkers).)Because these attributes are only available with the Swift 6.3 toolchain, we do not use them when building with Swift 6.2. Instead, if you build with Swift 6.2 you continue to use the "legacy" test discovery mechanism based on type metadata emission. The "legacy" mechanism will be removed in a future update.
Because the
_TestDiscoverytarget needs to continue to compile with Swift 6.2, I have not switched us over toobjectFormat()yet. See #1370 for details.Resolves #1371.
Checklist: