-
Notifications
You must be signed in to change notification settings - Fork 128
Provide prose documentation for attachments. #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR adds prose documentation explaining how to create attachments and add them to tests. Resolves #1143.
| /// | ||
| /// - ``Trait/savingAttachments(if:)`` | ||
| /// | ||
| /// By default, the testing library saves your attachments as soon as you call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is all SPI.
|
Tracked internally as rdar://164478451. |
jerryjrchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
| - When using Swift Package Manager's `swift test` command, you can pass the | ||
| `--attachments-path` option. The testing library saves attachments to the | ||
| specified directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clarify that if this CLI flag is not passed, attachments will not be saved anywhere? I wonder if that's even worth an "Important" callout or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave it as-is and let our DevPubs colleagues consider how to phrase it.
This PR adds prose documentation explaining how to create attachments and add them to tests.
Resolves #1143.
Checklist: