Skip to content

CustomLogStringConvertible should be SourceKit-LSP SPI #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

CustomLogStringConvertible should be SourceKit-LSP SPI #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/LanguageServerProtocolTransport/DocumentURI+CustomLogStringConvertible.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ extension DocumentURI {
return "<DocumentURI length=\(description.count) hash=\(description.hashForLogging)>"
}
}
extension DocumentURI: SKLogging.CustomLogStringConvertible {}
@_spi(SourceKitLSP) extension DocumentURI: SKLogging.CustomLogStringConvertible {}
4 changes: 2 additions & 2 deletions Sources/SKLogging/CustomLogStringConvertible.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public import Foundation

/// An object that can printed for logging and also offers a redacted description
/// when logging in contexts in which private information shouldn't be captured.
public protocol CustomLogStringConvertible: CustomStringConvertible, Sendable {
@_spi(SourceKitLSP) public protocol CustomLogStringConvertible: CustomStringConvertible, Sendable {
/// A full description of the object.
var description: String { get }

Expand Down Expand Up @@ -86,7 +86,7 @@ private struct OptionalWrapper<Wrapped>: CustomLogStringConvertible where Wrappe
}
}

extension Optional where Wrapped: CustomLogStringConvertible {
@_spi(SourceKitLSP) extension Optional where Wrapped: CustomLogStringConvertible {
@_spi(SourceKitLSP) public var forLogging: CustomLogStringConvertibleWrapper {
return CustomLogStringConvertibleWrapper(OptionalWrapper(optional: self))
}
Expand Down