TSCBasic: always report a dumb terminal on Windows #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Windows Terminal should provide a proper tty, for now, always report a dumb terminal. This repairs the rendering of C/C++ diagnostics. Thanks to @albertelrud for the amazing pointer on what it may be!
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
Member
Author
|
@swift-ci please test |
Member
Author
|
CC: @egorzhdan |
Member
Author
|
Filed SR-13594 to deal with the noted approach for improvement. |
neonichu
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Windows Terminal should provide a proper tty, for now, always
report a dumb terminal. This repairs the rendering of C/C++
diagnostics.
Thanks to @albertelrud for the amazing pointer on what it may be!