restore disabled FileSystemTests #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
motivation: better test coverage changes: * refactor the common part of testInMemoryFileSystemFileLock, testLocalFileSystemFileLock, testRerootedFileSystemViewFileLock * resove the potential reader race by making sure file have content prior to starting the threads * enable the above disabled tests in FileSystemTests rdar://71560894
Contributor
Author
|
@swift-ci please test |
benlangmuir
reviewed
Mar 18, 2021
Contributor
Author
|
@swift-ci please test |
benlangmuir
approved these changes
Mar 18, 2021
Contributor
benlangmuir
left a comment
benlangmuir
left a comment
There was a problem hiding this comment.
Looks great, thanks!
neonichu
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: better test coverage
changes:
rdar://71560894