Skip to content

Accommodate Android, where posix_spawnattr_t and posix_spawn_file_actions_t are opaque pointers #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2025
Merged

Accommodate Android, where posix_spawnattr_t and posix_spawn_file_actions_t are opaque pointers #523

merged 1 commit into from
Oct 25, 2025

Conversation

@jakepetroules
Copy link
Contributor

This is needed to compile on the Android platform.

@jakepetroules
Accommodate Android, where posix_spawnattr_t and posix_spawn_file_act…
ca42ca2 
…ions_t are opaque pointers

This is needed to compile on the Android platform.
@jakepetroules
Copy link
Contributor Author

@swift-ci test

@jakepetroules jakepetroules mentioned this pull request Oct 24, 2025
Open
@finagolfin
Copy link
Member

We currently match the Termux app headers instead, since this repo will mostly only be used for a native toolchain on Android. That app uses a backported posix_spawn that hasn't been updated in awhile, hence the disparity. I will update that backport then we can get this in to match.

marcprux
marcprux approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@marcprux marcprux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It build for me with swift build --swift-sdk aarch64-unknown-linux-android28.

owenv
owenv approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look to me like a DocC bug

@jakepetroules
Copy link
Contributor Author

@swift-ci test

@jakepetroules jakepetroules enabled auto-merge (rebase) October 24, 2025 21:41
@jakepetroules jakepetroules merged commit 847c107 into swiftlang:main Oct 25, 2025
3 checks passed
@jakepetroules jakepetroules deleted the eng/PR-android branch October 25, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

@marcprux marcprux marcprux approved these changes

@owenv owenv owenv approved these changes

@finagolfin finagolfin Awaiting requested review from finagolfin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakepetroules @finagolfin @compnerd @marcprux @owenv