[SR-2545] SIL verification failed: Opened archetype should be registered in SILFunction

[swift-ci]

Previous ID	SR-2545
Radar	None
Original Reporter	diegosanchezr (JIRA User)
Type	Bug
Status	Resolved
Resolution	Done

Attachment: Download

Environment

swift-DEVELOPMENT-SNAPSHOT-2016-08-31-a.xctoolchain
whole-module optimization

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, CompilerCrash, OptimizedOnly
Assignee	@swiftix
Priority	Medium

md5: bebf449163961ea3b276d8619d9d1b20

Issue Description:

Log is too long, see file attached.

STR:

1. Clone https://github.com/badoo/Chatto.git @ 2c0219f9
2. Open ./ChattoApp/ChattoApp.xcworkspace
3. Compile in Release configuration

It compiles in Debug configuration

[belkadan]

@bob-wilson, who should look at this?

[bob-wilson]

This sounds like it might be related to some of Roman's recent changes.

[swiftix]

Hi Diego,

I'm having troubles to reproduce the crash. I followed your instructions, checked out the repo and checked out the commit 2c0219f9 (which BTW seems to be the top of the swift-3 branch). I can build using in Release mode without any issues. Am I missing any steps?

[swift-ci]

Comment by Diego (JIRA)

I don't know. Are you opening ./ChattoApp/ChattoApp.xcworkspace instead of Chatto.xcworkspace right? (the fws do compile without problems). Also, I'm using macOS Sierra (16A313a).

I did some monkey patching. Applying this diffs gets rid of the crash.

diff --git a/ChattoApp/ChattoApp/Source/ChatItemsDemoDecorator.swift b/ChattoApp/ChattoApp/Source/ChatItemsDemoDecorator.swift
index 0779bae..e5f5446 100644
--- a/ChattoApp/ChattoApp/Source/ChatItemsDemoDecorator.swift
+++ b/ChattoApp/ChattoApp/Source/ChatItemsDemoDecorator.swift
@@ -59,13 +59,14 @@ final class ChatItemsDemoDecorator: ChatItemsDecoratorProtocol {
                     addTimeSeparator = true
                 }

-                if self.showsStatusForMessage(currentMessage) {
-                    additionalItems.append(
-                        DecoratedChatItem(
-                            chatItem: SendingStatusModel(uid: "\(currentMessage.uid)-decoration-status", status: currentMessage.status),
-                            decorationAttributes: nil)
-                    )
-                }
+//                if self.showsStatusForMessage(currentMessage) {
+//                    additionalItems.append(
+//                        DecoratedChatItem(
+//                            chatItem: SendingStatusModel(uid: "\(currentMessage.uid)-decoration-status", status: currentMessage.status),
+//                            decorationAttributes: nil)
+//                    )
+//                }

But adding a simple print(currentMessage.status) in that place brings it back

[swiftix]

My bad. I was building Chatto, not ChattoApp. I could reproduce now. Thanks!
Looking into it.

[swiftix]

Fixed on swift/master. Commit bb106ee

Diego, it would be nice if you could check that it fixes your issue.

[swift-ci]

Comment by Diego (JIRA)

Hi Roman, I just compiled a toolchain from master, and this specific issue is gone. Thank you! Can I expect Xcode 8 to be free from this bug?

This toolchain however seems to introduce a separate bug:

Undefined symbols for architecture x86_64:
  "ChattoApp.BaseMessageCollectionViewCellAvatarStyle.(init (colors : ChattoAdditions.BaseMessageCollectionViewCellDefaultStyle.Colors, bubbleBorderImages : ChattoAdditions.BaseMessageCollectionViewCellDefaultStyle.BubbleBorderImages?, failedIconImages : ChattoAdditions.BaseMessageCollectionViewCellDefaultStyle.FailedIconImages, layoutConstants : ChattoAdditions.BaseMessageCollectionViewCellLayoutConstants, dateTextStyle : ChattoAdditions.BaseMessageCollectionViewCellDefaultStyle.DateTextStyle, avatarStyle : ChattoAdditions.BaseMessageCollectionViewCellDefaultStyle.AvatarStyle) -> ChattoApp.BaseMessageCollectionViewCellAvatarStyle).(default argument 1)", referenced from:

Looks like the initializer from BaseMessageCollectionViewCellDefaultStyle didn't get inherited in my ChattoApp subclass, as I can workaround it with

diff --git a/ChattoApp/ChattoApp/Source/BaseMessageCollectionViewCellAvatarStyle.swift b/ChattoApp/ChattoApp/Source/BaseMessageCollectionViewCellAvatarStyle.swift
index 40f32e4..9d32d9d 100644
--- a/ChattoApp/ChattoApp/Source/BaseMessageCollectionViewCellAvatarStyle.swift
+++ b/ChattoApp/ChattoApp/Source/BaseMessageCollectionViewCellAvatarStyle.swift
@@ -30,4 +30,9 @@ class BaseMessageCollectionViewCellAvatarStyle: BaseMessageCollectionViewCellDef
         // Display avatar for both incoming and outgoing messages for demo purpose
         return CGSize(width: 35, height: 35)
     }
+
+    init() {
+        super.init()
+    }
+
 }

Should I open a separate issue with this?

Thank you again!

[swiftix]

> Hi Roman, I just compiled a toolchain from master, and this specific issue is gone. Thank you! Can I expect Xcode 8 to be free from this bug?

I cannot say for sure which changes are going to be included into the upcoming Xcode release. All changes not included into the upcoming one would be included into the next one though.

As for the other issue, please file a separate issue for it.

[swift-ci]

Comment by Diego (JIRA)

Thank you, filled SR-2558