[SR-4383] Runtime Error: cyclic metadata dependency detected, aborting

[SusanDoggie]

Previous ID	SR-4383
Radar	None
Original Reporter	@SusanDoggie
Type	Bug
Status	Resolved
Resolution	Duplicate

Attachment: Download

Environment

Xcode 8.3

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, RunTimeCrash, Runtime
Assignee	None
Priority	Medium

md5: 55aa64f1ae8697e9ffe1fd6b49722f36

duplicates:

• SR-263 Implement a general solution to prevent deadlocks when generic types rely on their own metadata recursively

relates to:

• SR-1686 Program with recursive class crashes because of “cyclic metadata dependency”

Issue Description:

generic structure extension with concrete type in framework cause runtime error:
GenericCache(0x109f18720): cyclic metadata dependency detected, aborting

[belkadan]

It would be nice if we printed which metadata had a cycle. cc @jckarter, @rjmccall

[SusanDoggie]

Is there any workarounds? The bug stop me using Swift 3.1 for development.

[belkadan]

This error means you're already outside of valid Swift code. If code was accepted in 3.0 that is now causing this error in 3.1, that's a problem, but it's not something that was ever guaranteed to work.

If you look at the stack trace for the crash, you might be able to find out which types are causing the problem.

[SusanDoggie]

not exactly

i have minimised the project and it can reproduce the bug

[SusanDoggie]

I found that it fixes the problem if I move the enum Base to the outside of Bezier structure

[belkadan]

Huh. It's unfortunate that that runs afoul of the cyclic metadata check, but I think not a surprise today. The layout of 'Bezier' depends on the layout of 'Base', but the metadata for 'Base' has a "parent" pointer that refers to the metadata for 'Bezier'. We ought to be able to handle this since the parent pointer isn't used for layout, but we currently cannot.

[ctxppc]

I had the same problem, also involving an enum type contained in a struct type. Since it’s apparently a problem with layout, I thought I’d add the “indirect” keyword to that inner enum to decouple the enum layout from the rest, which resolved the issue. Unit tests in my project pass.

Given that my enum uses stdlib types only for associated values, there’s no recursive reference back to the enum. Is “indirect” the recommend way to go in an “ideal” compiler? I wouldn’t want to resolve to “indirect” (seems like a hack) unless that’s intended behaviour in the model.

In any case, a more detailed diagnostic of cycles would be great. :-)