[SR-4518] Remote mirrors needs to support multi-payload enums

[swift-ci]

Previous ID	SR-4518
Radar	rdar://31666592
Original Reporter	Jay18001 (JIRA User)
Type	Bug

Attachment: Download

Environment

I've only tested on iOS 10.3 with Xcode 8.3 on 10.12.3 (16D32)

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, Leak
Assignee	@mikeash
Priority	Medium

md5: d6c09cb4c02ae76ce77a67ef1ead510e

Issue Description:

There is a swift_slowAlloc leak when using an enum like the following. The leak only occurs when the second case is used in the third like auto(estimate: .fixed(size: 10)).

public indirect enum Enum {
case ratio(ratio: CGFloat)
 case fixed(size: CGFloat)
 case auto(estimate: Enum)
}

However it does not accure when the first case is used with the third like auto(estimate: .ratio(ratio: 10))

[belkadan]

I think this is a (known) bug in our leaks tool rather than an actual leak; looping the offending line of code forever did not seem to increase memory usage in a quick test. @jckarter?

[jckarter]

@slavapestov would be better able to comment on that. IIRC some of those issues got fixed in iOS 10.3, but according to this bug this one is still happening in 10.3.

[slavapestov]

The remote mirrors library does not support multi-payload enums yet unfortunately.

[slavapestov]

Looks like this was fixed in Swift 5.7.