[SR-5794] Expand a ternary operator into an if statement and vice-versa

[akyrtzi]

Previous ID	SR-5794
Radar	rdar://32751037
Original Reporter	@akyrtzi
Type	New Feature
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	Source Tooling
Labels	New Feature, Refactoring, StarterProposal
Assignee	romanroibu (JIRA)
Priority	Medium

md5: 4c821f590e264347c4d79d13cd5eb470

Issue Description:

When selecting a ternary expression

    let x = expression ? a : b

Suggest expanding to an if-else:

    let x: Int
    if expression {
        x = a
    } else {
        x = b
    }

And vice-versa.

[swift-ci]

Comment by Roman Roibu (JIRA)

Hi @akyrtzi,

Is anybody working on this issue?
If not, I would like to give it a try, though I might have some questions along the way.

Thanks!

[akyrtzi]

Is anybody working on this issue?

Not AFAIK. Note that it is 'Unassigned'.

[swift-ci]

Comment by KacperHarasim (JIRA)

Hi romanroibu (JIRA User), are you working on this? Asking because the issue is still unassigned. Thanks!

[swift-ci]

Comment by Roman Roibu (JIRA)

Hi kacperh (JIRA User). Yes, I'm working on this, but making slow progress. I'll change the assignee status, thanks!

[swift-ci]

Comment by KacperHarasim (JIRA)

Great

[swift-ci]

Comment by Roman Roibu (JIRA)

Opened a PR to implement this: #12554

[akyrtzi]

Is this resolved ?

[NachoSoto]

PR is merged, but this isn't on Xcode 9.3 beta 1?

[akyrtzi]

This came after the 'swift-4.1' branch and was not merged to that. We should have notified Roman to do another PR for swift-4.1.

Unfortunately, at this point we are in convergence mode and only aim to get critical fixes into that branch.

[swift-ci]

Comment by Anton Vlasov (JIRA)

This works fine at Xcode 10.1 (10B61). I think the issue should be closed.