[SR-6800] Swift 4.1 regression: compiler crash with optimizations (instrprof failed to lower an increment UNREACHABLE executed)

[NachoSoto]

Previous ID	SR-6800
Radar	rdar://problem/36675957
Original Reporter	@NachoSoto
Type	Bug
Status	Resolved
Resolution	Duplicate

Environment

Swift version 4.1-dev (LLVM ef53654946, Clang f7df1e5a04, Swift 831b78c)

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, 4.1Regression, CompilerCrash
Assignee	@vedantk
Priority	Medium

md5: 3dabdb63c4ad6cef364d7b857ba5162c

blocks:

• SR-6846 Swift 4.1 compiler crash with optimization

Issue Description:

After converting AsyncImageView to Swift 4.1, I compiled it with Carthage and realized it crashes the compiler (not in Debug). You can clone the branch on that exact state from the repo or download it directly from here.

Once open, select the AsyncImageView-iOS scheme and compile (I already set it to Release configuration).

Stack trace:

instrprof failed to lower an increment
UNREACHABLE executed at /Users/buildnode/jenkins/workspace/oss-swift-4.1-package-osx/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5850!
0  swift                    0x000000010e104ab8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
1  swift                    0x000000010e103a06 llvm::sys::RunSignalHandlers() + 86
2  swift                    0x000000010e10507e SignalHandler(int) + 366
3  libsystem_platform.dylib 0x00007fff54770f5a _sigtramp + 26
4  libsystem_platform.dylib 0x000000011a41b558 _sigtramp + 3318392344
5  libsystem_c.dylib        0x00007fff5459b312 abort + 127
6  swift                    0x000000010e0a5860 LLVMInstallFatalErrorHandler + 0
7  swift                    0x000000010c7ca6a7 llvm::SelectionDAGBuilder::visitIntrinsicCall(llvm::CallInst const&, unsigned int) + 43127
8  swift                    0x000000010c7a704f llvm::SelectionDAGBuilder::visitCall(llvm::CallInst const&) + 239
9  swift                    0x000000010c79d5b9 llvm::SelectionDAGBuilder::visit(llvm::Instruction const&) + 105
10 swift                    0x000000010c8266cf llvm::SelectionDAGISel::SelectBasicBlock(llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction, true, false, void>, false, true>, llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction, true, false, void>, false, true>, bool&) + 127
11 swift                    0x000000010c82588f llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) + 7423
12 swift                    0x000000010c822ad3 llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) + 2035
13 swift                    0x000000010bed6434 (anonymous namespace)::X86DAGToDAGISel::runOnMachineFunction(llvm::MachineFunction&) + 20
14 swift                    0x000000010cb9fa1c llvm::MachineFunctionPass::runOnFunction(llvm::Function&) + 172
15 swift                    0x000000010dfed4ad llvm::FPPassManager::runOnFunction(llvm::Function&) + 509
16 swift                    0x000000010dfed723 llvm::FPPassManager::runOnModule(llvm::Module&) + 67
17 swift                    0x000000010dfedba0 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 752
18 swift                    0x000000010ade492d swift::performLLVM(swift::IRGenOptions&, swift::DiagnosticEngine*, llvm::sys::SmartMutex<false>*, llvm::GlobalVariable*, llvm::Module*, llvm::TargetMachine*, swift::version::Version const&, llvm::StringRef, swift::UnifiedStatsReporter*) + 3485
19 swift                    0x000000010ade9755 ThreadEntryPoint(swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int) + 517
20 swift                    0x000000010adea86f void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int), swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int> >(void*) + 47
21 libsystem_pthread.dylib  0x00007fff5477a6c1 _pthread_body + 340
22 libsystem_pthread.dylib  0x00007fff5477a56d _pthread_body + 0
23 libsystem_pthread.dylib  0x00007fff54779c5d thread_start + 13
Stack dump:
0.  Running pass 'Function Pass Manager' on module '/Users/nachosoto/Library/Developer/Xcode/DerivedData/Build/Intermediates/AsyncImageView.build/Release-iphonesimulator/AsyncImageView-iOS.build/Objects-normal/x86_64/Renderer.o'.
1.  Running pass 'X86 DAG->DAG Instruction Selection' on function '@_T014AsyncImageViewAACAByxq_q0_q1_GSC6CGRectV12initialFrame_q0_8rendererq1_Sg19placeholderRenderer13ReactiveSwift9Scheduler_p02uiL0AjK_p013imageCreationL0tcfcfA2_'

See also SR-6797 and SR-6799.

[slavapestov]

@swift-ci create

[slavapestov]

For once, a bug in LLVM and not Swift!

[NachoSoto]

Yay?

[vedantk]

@NachoSoto could you provide some more instructions for reproducing this crash? Simply compiling it in Xcode does not work (there's a build error about ReactiveSwift being built already for 4.0.1). Do I need to run a carthage command first? Thanks.

[NachoSoto]

Can you try removing derived data? The correct framework is already built in the repo. Make sure you're using the AsyncImageView-iOS schema!

[vedantk]

I wiped the derived data in ~/Library/Developer/Xcode, but am still seeing:

Module compiled with Swift 4.1 cannot be imported in Swift 4.0.1: /Users/vk/Desktop/AsyncImageView-swift-4-1-release/Carthage/Build/iOS/ReactiveSwift.framework/Modules/ReactiveSwift.swiftmodule/x86_64.swiftmodule

Should I wipe the Carthage Build directory as well?

[vedantk]

Ah, oops, I'm not building with a new enough swift. Sorry for the noise.

[NachoSoto]

Oh yeah, I thought you meant the opposite.
Let me know if it's "building" now 🙂

[vedantk]

Hm, I'm building with this swift, but it's still not the right version:

/Library/Developer/Toolchains/swift-4.1-DEVELOPMENT-SNAPSHOT-2018-01-18-a.xctoolchain/usr/bin/swift --version
Apple Swift version 4.1-dev (LLVM ef53654946, Clang f7df1e5a04, Swift 831b78c)
Target: x86_64-apple-darwin16.7.0

Do you have a link to a working dev snapshot (from https://swift.org/download/#snapshots)? Thanks again for your help.

[NachoSoto]

Are you getting the same error? I built this using the latest snapshot for 4.1

If you need to, you can rebuild dependencies with the following command:

carthage build --platform ios --toolchain {ToolchainID}

[vedantk]

Yes, I'm seeing the same error:

Module compiled with Swift 4.0.3 cannot be imported in Swift 4.1: /Users/vk/Desktop/AsyncImageView/Carthage/Build/iOS/ReactiveSwift.framework/Modules/ReactiveSwift.swiftmodule/i386.swiftmodule

I'm using the latest 4.1 snapshot ("Swift 4.1 Development" on this page: https://swift.org/download/#snapshots ), but the ReactiveSwift module included in your package is built with 4.0.3:

00001ec0 10 22 a4 12 07 94 0d 00 52 65 61 63 74 69 76 65 |."......Reactive|
00001ed0 53 77 69 66 74 00 00 00 05 00 68 0b 28 28 70 05 |Swift.....h.((p.|
00001ee0 34 2e 30 2e 33 28 34 2e 30 2e 33 29 2f 41 70 70 |4.0.3(4.0.3)/App|
00001ef0 6c 65 20 53 77 69 66 74 20 76 65 72 73 69 6f 6e |le Swift version|
00001f00 20 34 2e 30 2e 33 20 28 73 77 69 66 74 6c 61 6e | 4.0.3 (swiftlan|
00001f10 67 2d 39 30 30 2e 30 2e 37 34 2e 31 20 63 6c 61 |g-900.0.74.1 cla|
00001f20 6e 67 2d 39 30 30 2e 30 2e 33 39 2e 32 29 00 00 |ng-900.0.39.2)..|

I suppose I need to rebuild the dependencies, but I'm not sure how to do that as I'm unfamiliar with carthage. The carthage command you provided doesn't look like it's rebuilding anything:

$ carthage build --platform ios --toolchain XcodeDefault

• • • xcodebuild output can be found in /var/folders/nw/6dc3t26s1d721jg_61pvhjg80000gn/T/carthage-xcodebuild.qF3xbC.log

    • Fetching RandomKit

Would it be possible for you to share a package where ReactiveSwift is compiled with the 4.1 snapshot? If I'm misunderstanding your instructions – apologies!

[NachoSoto]

I'm happy to help! Is there any chance we can use any form of IM to speed this up? I can help you diagnose why Carthage isn't building.
I think that's going to be more useful than my building everything again, cause by the time I do that there's going to be a new snapshot...

[vedantk]

@NachoSoto thanks, feel free to direct-message me on IRC. I'm on the #llvm channel on OFTC as vedantk (https://llvm.org/docs/#irc).

Could you also attach the full swift compiler invocation which crashes? It might rule out a few types of issues.

[NachoSoto]

I don't use IRC...
Can you verify that you have the latest version of Carthage? You should have 0.27.0 ($ carthage version).

[NachoSoto]

@vedantk okay, now that Xcode 9.3 beta 1 is out, you can test this with that version. I just updated the branch to use that version of the compiler.

If you still need to build by hand, the command I mentioned should work (I don't know if "XcodeDefault" is a valid toolchain though, you need the ID). But again, make sure you have the latest version of Carthage installed.