[SR-15105] Source compatibility suite: FAIL: siesta, 5.1, cb9c1b, Swift Package: duplicate symbol '_NDR_record'

[hamishknight]

Previous ID	SR-15105
Radar	rdar://problem/82303284
Original Reporter	@hamishknight
Type	Bug

Environment

swift-main-source-compat-suite
swift-main-source-compat-suite-debug
swift-5.5-source-compat-suite

Additional Detail from JIRA

Votes	0
Component/s
Labels	Bug
Assignee	None
Priority	Medium

md5: c04cf32deba14c05720d7fe43ebbf716

Issue Description:

https://ci.swift.org/job/swift-main-source-compat-suite/6084/
https://ci.swift.org/job/swift-5.5-source-compat-suite/139/

siesta is failing with:

error: link command failed with exit code 1 (use -v to see invocation)
duplicate symbol '_NDR_record' in:
    /Volumes/swift-ci/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/siesta/.build/x86_64-apple-macosx/release/CwlPreconditionTesting.build/CwlBadInstructionException.swift.o
    /Volumes/swift-ci/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/siesta/.build/x86_64-apple-macosx/release/CwlPreconditionTesting.build/CwlCatchBadInstruction.swift.o

And in a debug run https://ci.swift.org/job/swift-main-source-compat-suite-debug/4198/,
both siesta and Nimble fail with:

<unknown>:0: error: symbol 'NDR_record' (NDR_record) is in generated IR file, but not in TBD file
<unknown>:0: error: please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project, and add '-Xfrontend -validate-tbd-against-ir=none' to squash the errors

Looks like this has been worked around upstream in mattgallagher/CwlPreconditionTesting@0630439888c94657a235ffcd5977d6047ef3c87b, although Nimble and siesta don't yet have it in their dependencies.

[hamishknight]

cc @pcantrell @ikesyo

[hamishknight]

@nkcsgexi Is the "symbol 'NDR_record' (NDR_record) is in generated IR file, but not in TBD file" crash in the debug build expected behavior for this?

[pcantrell]

Forgive me for my confusion, but is some action necessary on my (Siesta maintainer’s) part?

My impression was that old versions of code in the source compat suite should never change, to ensure that existing code continues to work as is.

[hamishknight]

XFAILing in swiftlang/swift-source-compat-suite#576

[hamishknight]

Sorry for the confusion @pcantrell, let me double check what the expected behavior is here

[hamishknight]

Okay, it seems likely this a compiler bug, sorry for the noise!

[hamishknight]

@swift-ci create