[SR-15116] Source compatibility suite: FAIL: ACHNBrowserUI & MovieSwift

[hamishknight]

Previous ID	SR-15116
Radar	rdar://82333521
Original Reporter	@hamishknight
Type	Bug

Environment

swift-main-source-compat-suite
swift-main-source-compat-suite-debug
swift-5.5-source-compat-suite

Additional Detail from JIRA

Votes	0
Component/s
Labels	Bug
Assignee	None
Priority	Medium

md5: e8a062ec6f6064eefd1ddfdef15ade39

Issue Description:

https://ci.swift.org/job/swift-main-source-compat-suite/6086/
https://ci.swift.org/job/swift-main-source-compat-suite-debug/4200/
https://ci.swift.org/job/swift-5.5-source-compat-suite/140/

Both ACHNBrowserUI & MovieSwift are failing to clone some of their dependencies:

xcodebuild: error: Could not resolve package dependencies:
  Failed to clone repository https://github.com/RevenueCat/purchases-ios:
    Cloning into bare repository '/Users/buildnode/Library/Developer/Xcode/DerivedData/ACHNBrowserUI-arljdbwzwowzzvefsixnihpbnxws/SourcePackages/repositories/purchases-ios-fbdec518'...
    fatal: unable to access 'https://github.com/RevenueCat/purchases-ios/': Could not resolve host: github.com

This is because they're trying to clone once the sandbox has already been imposed:

$ sandbox-exec -f /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb xcodebuild clean build -project /Users/buildnode/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/ACHNBrowserUI/ACHNBrowserUI/ACHNBrowserUI.xcodeproj -target ACHNBrowserUI -destination generic/platform=iOS SYMROOT=/Users/buildnode/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/ACHNBrowserUI/build CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENTITLEMENTS_REQUIRED=NO ENABLE_BITCODE=NO INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO SWIFT_TREAT_WARNINGS_AS_ERRORS=NO SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-main-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc -IDEPackageSupportDisableManifestSandbox=YES -configuration Release SWIFT_VERSION=5 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) -swift-version 5' DEBUG_INFORMATION_FORMAT=dwarf
2021-08-24 19:40:04.050 xcodebuild[11782:1261998] CoreText: System LastResort not available, using built-in copy.

The dependencies need to be fetched before the sandbox is imposed.

[hamishknight]

XFAILing in swiftlang/swift-source-compat-suite#576

[hamishknight]

cc Dimillian (JIRA User)

[swift-ci]

Comment by Thomas Ricouard (JIRA)

So nothing on my end to do? I'll need to update the commit in the source combat repo eventually.

[hamishknight]

Ah sorry, from the log it looked like the projects were trying to manually clone dependencies during building, but it seems to be caused by embedded Swift Packages in the Xcode project, @shahmishal @clackary are we able to support this?