term "non-isolated" appears in diagnostic

[mattmassicotte]

Description

Per #73982, the compiler seems to have standarized on using the spelling "nonisolated" in prose. However, here's an example where "non-isolated" is used.

test.swift:4:5: error: main actor-isolated var 'global' can not be mutated from a non-isolated context
1 | var global = 42
  |     `- note: mutation of this var is only permitted within the actor
2 | 
3 | func mutate() {
  |      `- note: add '@MainActor' to make global function 'mutate()' part of global actor 'MainActor'
4 |     global += 1
  |     `- error: main actor-isolated var 'global' can not be mutated from a non-isolated context
5 | }
6 | 

Reproduction

var global = 42

func mutate() {
    global += 1
}

Expected behavior

"nonisolated" should be used everywhere

Environment

Apple Swift version 6.0-dev (LLVM 5b37bd4c1c578e9, Swift 54898ce)
Target: arm64-apple-macosx14.0

Additional information

No response

[mattmassicotte]

It's also not too late to take this opportunity to, instead, move to "non-isolated" everywhere outside source!

("nonisolated" is not in the en_US spelling dictionary that ships with macOS, and while I know that's an easy one to fix, still reads very weird to me)

[EngOmarElsayed]

@hborla I want to fix this issue. How can I start ?

[ktoso]

Thanks for wanting to contribute!

This specific issue I believe was already solved though:

ERROR(isolated_property_mutation_in_nonisolated_context,none,
      "actor-isolated %kind0 can not be %select{referenced|mutated}1 "
      "from a nonisolated context",
      (const ValueDecl *, bool))

Generally for messages you'd go look in the DiagnosticsSIL.def file and adjust them; and their use accordingly. this was fixed in 474aa47 already though

[ktoso]

Please have a look at other good first issues though, thank you! @EngOmarElsayed !