[DO NOT MERGE] Removed PlaygroundQuickLook, CustomPlaygroundQuickLookable, and friends. #14252
Conversation
|
Please test with the following PRs: swiftlang/swift-corelibs-foundation#1415 @swift-ci Please test |
|
Build failed |
|
@swift-ci Please test OS X platform |
|
Build failed |
|
Please test with the following PRs: swiftlang/swift-corelibs-foundation#1415 @swift-ci Please test OS X platform |
|
Please test with the following PRs: swiftlang/swift-corelibs-foundation#1415 @swift-ci Please test source compatibility |
…nd _DefaultCustomPlaygroundQuickLookable.
…overlay. The CustomPlaygroundQuickLookable conformances have been deleted, so this is no longer required.
`import CoreGraphics` is required for this test on non-macOS Apple platforms. (On macOS, `import Foundation` is sufficient.) This previously was not an issue, as this test used to `import UIKit` on non-macOS Apple platforms. Since CoreGraphics is available everywhere this test runs, and this test does test CoreGraphics types, I just added an import of CoreGraphics.
cwakamo
force-pushed
the
remove-PlaygroundQuickLook-and-friends
branch
from
dc70faf to
68cca77
Compare
|
Please test with the following PRs: swiftlang/swift-corelibs-foundation#1415 @swift-ci Please test |
|
Build failed |
|
Build failed |
|
Please test with the following PRs: swiftlang/swift-corelibs-foundation#1415 @swift-ci Please test source compatibility |
CodaFi
added
the
swift evolution pending discussion
|
@cwakamo Was this PR superseded by another? The proposal says it was accepted and implemented. |
|
Closing this PR as we did not end up going in this direction. |
|
Proposal: SE-0198 |
AnthonyLatsis
removed
the
swift evolution pending discussion
5 participants
This pull request removes the
PlaygroundQuickLookenum, theCustomPlaygroundQuickLookableprotocol, and the runtime pieces which supportedPlaygroundQuickLook.init(reflecting:).This is the implementation of an upcoming swift-evolution proposal which aims to remove these types from the standard library and replace them with a new
CustomPlaygroundDisplayConvertibleprotocol in the PlaygroundSupport library.