Skip to content

Add a test case for AST verification of loaded modules in WMO. #14278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2018
Merged

Add a test case for AST verification of loaded modules in WMO. #14278

merged 1 commit into from
Jan 31, 2018

Conversation

@atrick
Copy link
Contributor

@atrick atrick commented Jan 30, 2018

Prior to the following commit, the SILVerifier will assert
on this test case.

PR: 14250 #14250

commit deebe8b
Author: Andrew Trick atrick@apple.com
Date: Mon Jan 29 15:22:28 2018

performTypeChecking: Defer verifyAllLoadedModules in WMO mode.

@atrick atrick requested a review from jrose-apple January 30, 2018 19:03
@atrick
Copy link
Contributor Author

atrick commented Jan 30, 2018

@swift-ci test.

@jrose-apple
Copy link
Contributor

jrose-apple commented Jan 30, 2018

Looks good, although such a finicky test probably belongs in validation-test.

@atrick
Copy link
Contributor Author

atrick commented Jan 30, 2018

@jrose-apple Do you want me to move this test? I think validation tests should be less likely to break.

@swift-ci
Copy link
Contributor

swift-ci commented Jan 30, 2018

Build failed
Swift Test OS X Platform
Git Sha - 62fb16c6b704e029e796972d4eb9a92a3d460aab

@swift-ci
Copy link
Contributor

swift-ci commented Jan 30, 2018

Build failed
Swift Test Linux Platform
Git Sha - 62fb16c6b704e029e796972d4eb9a92a3d460aab

@atrick
Copy link
Contributor Author

atrick commented Jan 30, 2018

@swift-ci test.

@swift-ci
Copy link
Contributor

swift-ci commented Jan 30, 2018

Build failed
Swift Test Linux Platform
Git Sha - 62fb16c6b704e029e796972d4eb9a92a3d460aab

@swift-ci
Copy link
Contributor

swift-ci commented Jan 30, 2018

Build failed
Swift Test OS X Platform
Git Sha - 62fb16c6b704e029e796972d4eb9a92a3d460aab

@jrose-apple
Copy link
Contributor

jrose-apple commented Jan 30, 2018

I don't think validation tests are "less likely to break" so much as "take more time to run" and/or "are less well-defined". This fits in the latter category, at least.

@jrose-apple
Copy link
Contributor

jrose-apple commented Jan 30, 2018

It's not that important, though.

@atrick
Add a test case for AST verification of loaded modules in WMO.
dd2e348 
Prior to the following commit, the SILVerifier will assert
on this test case.

PR: 14250 <#14250>

commit deebe8b
Author: Andrew Trick <atrick@apple.com>
Date:   Mon Jan 29 15:22:28 2018

    performTypeChecking: Defer verifyAllLoadedModules in WMO mode.
@atrick
Copy link
Contributor Author

atrick commented Jan 30, 2018

@swift-ci test and merge.

1 similar comment
@atrick
Copy link
Contributor Author

atrick commented Jan 30, 2018

@swift-ci test and merge.

@swift-ci swift-ci merged commit dade1d9 into swiftlang:master Jan 31, 2018
@atrick atrick deleted the ast-verify-test branch May 9, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrose-apple jrose-apple Awaiting requested review from jrose-apple

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atrick @jrose-apple @swift-ci