Tidy up debug printing and dumping a bit, moving from errs() to dbgs() #17398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jun 21, 2018
mhong
approved these changes
Jun 21, 2018
mhong
left a comment
mhong
left a comment
There was a problem hiding this comment.
Nice!
What's the benefit of using dbgs() over errs()?
I understand the use of DEBUG(). For dbgs(), does it allow user to dump the output somewhere else (and if so, how?)
Contributor
Author
|
The only advantage is that it is more consistent with the rest of the codebase. DEBUG goes away in release builds too. |
marcrasi
pushed a commit
that referenced
this pull request
Jun 22, 2018
#17398) Tidy up debug printing and dumping a bit, moving from errs() to dbgs() in a few places.
marcrasi
pushed a commit
that referenced
this pull request
Jun 28, 2018
#17398) Tidy up debug printing and dumping a bit, moving from errs() to dbgs() in a few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up debug printing and dumping a bit, moving from errs() to dbgs()
in a few places.