Enable benchmark test only when the binary is present #18141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the condition that enables `benchmark` feature, to depend on the presence of the `Benchmark_O` binary directly, instead of the `@SWIFT_BUILD_PERF_TESTSUITE@`.
|
@jrose-apple Please review 🙏 CC: @eeckstein, @gottesmm |
|
Thanks, this looks good to me! Let's see if Erik has any concerns, though. @swift-ci Please smoke test |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @jrose-apple in the discussion after the #12415 has landed:
Changed the condition that enables
benchmarkfeature, to depend on the presence of theBenchmark_Obinary directly, instead of the@SWIFT_BUILD_PERF_TESTSUITE@.