fix VJP differentiation for TensorFlow autodiff tests #21106

marcrasi · 2018-12-07T00:05:31Z

Fixes/workarounds for some issues:

make vjps noinline and nonspecializable to workaround a problem in deabstraction (more details in comment)
remove the PublicNonABI linkage for vjps, because linking fails when noinline vjps are PublicNonABI
make getTFCompatibleFuncName able to handle AD__ functions
I got a SILVerifier error when running TensorFlow/tensor_autodiff.swift in vjp mode. Adding the default arguments for matmul seems to fix it.

The SILVerifier error was:

SIL verification failed: external declarations of SILFunctions with shared visibility is not allowed: SingleFunction || !hasSharedVisibility(RefF->getLinkage()) || RefF->hasForeignBody()
Verifying instruction:
->   // function_ref default argument 2 of static Raw.matMul<A>(_:_:transposeA:transposeB:)
  %3 = function_ref @$s10TensorFlow3RawO6matMul__10transposeA0F1BAA0A0VyxGAI_AIS2btSjRzAA0aB6ScalarRzlFZfA1_ : $@convention(thin) <τ_0_0 where τ_0_0 : Numeric, τ_0_0 : TensorFlowScalar> () -> Bool // user: %4
     %4 = apply %3<Scalar>() : $@convention(thin) <τ_0_0 where τ_0_0 : Numeric, τ_0_0 : TensorFlowScalar> () -> Bool // user: %8

I believe that my PublicNonABI change will bring back https://bugs.swift.org/browse/SR-8723. I don't have swift set up on a macos right now (and I've only seen this failure happen on macos), so I'll run this PR through macos ci to see what happens. Maybe I can fix this by teaching TBDGen to generate symbols for autodiff associated functions?

marcrasi · 2018-12-07T00:06:15Z

@swift-ci please test tensorflow macos

rxwei · 2018-12-07T00:08:24Z

You can also try to remove non-abi linkage from primal/adjoint functions. @bgogul encountered exactly this verifier error yesterday, so this may fix his problem.

rxwei · 2018-12-07T00:14:39Z

I believe that my PublicNonABI change will bring back https://bugs.swift.org/browse/SR-8723. I don't have swift set up on a macos right now (and I've only seen this failure happen on macos), so I'll run this PR through macos ci to see what happens. Maybe I can fix this by teaching TBDGen to generate symbols for autodiff associated functions?

Yes. Let's discuss this offline tomorrow.

rxwei · 2018-12-08T14:27:48Z

lib/TBDGen/TBDGen.cpp

Clean up the empty line?

marcrasi · 2018-12-12T02:27:24Z