[AutoDiff] Use @_fieldwiseDifferentiable on struct decls and deprecate @_fieldwiseProductSpace.
#22009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate `@_fieldwiseProductSpace`. * Derived conformances for `Differentiable` puts `@_fieldwiseProductSpace` on either all associated types or none, so it is redundant to keep this attribute on every typealias in a `Differentiable` type. Instead, we move it up to the parent struct decl so that it simplifies both derivation and checking. * Simplify `struct_extract` differentiation logic and improve code style. * Remove legacy `lookUpOrLinkFunction` and have everything go through `DifferentiationTask`.
Contributor
Author
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jan 20, 2019
Contributor
dan-zheng
left a comment
dan-zheng
left a comment
There was a problem hiding this comment.
Great simplification of the semantics of @_fieldwiseDifferentiable 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived conformances for
Differentiableput@_fieldwiseProductSpaceon either all associated types or none, so it is redundant to keep this attribute on every typealias in aDifferentiabletype. Instead, we move it up to the parent struct decl so that it simplifies both derivation and checking.Simplify
struct_extractdifferentiation logic and improve code style.Remove legacy
lookUpOrLinkFunctionand have everything go throughDifferentiationTask.