workaround new autocomplete crasher #22942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test tensorflow |
rxwei
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building against the latest swift-apis reveals a new autocomplete crasher: the autocompleter cannot deal with the "sequenced" method introduced in tensorflow/swift-apis#20.
I tried to investigate a bit, but it's something non-obvious happening deep within substitution map stuff. So I think the safest way to make the autocompleter not crash in v0.2 release is to suppress "sequenced" as an autocomplete result.
https://bugs.swift.org/browse/TF-315 has details about the crash.