[AutoDiff] [stdlib] Add operators for custom gradients. #23036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
reviewed
Mar 2, 2019
stdlib/public/core/AutoDiff.swift
Outdated
There was a problem hiding this comment.
withGradient(_ body: @escaping (CotangentVector) -> CotangentVector) seems like a more natural API at first glance. Do you have a reason to do it this way?
Contributor
Author
There was a problem hiding this comment.
I think my core rationale is that withXXX APIs in Swift usually return whatever the closure returns, e.g. withUnsafePointer(_:) and withoutAcutallyEscaping(_:), so x.withGradient { $0 + 1 } would syntactically indicate to a Swift programmer that this is "returning the gradient plus one in the forward pass".
Forbidding a return value makes it slightly less misleading. We can totally change this later.
marcrasi
approved these changes
Mar 2, 2019
Contributor
Author
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For demo purposes.