[AutoDiff] Fix @differentiating attribute.
#23441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
commented
Mar 20, 2019
lib/AST/Attr.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
Using the location of decl's name here (DeclNameLoc(decl->getNameLoc())) might not make sense.
Contributor
Author
|
@swift-ci Please test tensorflow |
Update derivative name in `@differentiable` attribute when a derivative
function is set. This prevents linker errors.
Disable serialization for `@differentiable` attribute. It is unnecessary:
- Currently, type-checking sets the derivative in a `@differentiable` attribute
on the original function, which is serialized.
- If both `@differentiable` and `@differentiating` are serializable, using
`@differentiating` attribute causes an infinite loop occurs during
deserialization.
- In the future, `@differentiating` attribute will be lowered to SIL
differentiability witness tables, which will be serialized.
Unblocks swiftlang#23193: using `@differentiating` attribute in the stdlib.
dan-zheng
force-pushed
the
fix-differentiating-attr
branch
from
de21726 to
541f005
Compare
Contributor
Author
|
@swift-ci Please test tensorflow |
Fix serialization tests. In `test/Serialization/differentiating_attr.swift`, check that generated `@differentiable` attribute is correct:
Contributor
Author
|
@swift-ci Please test tensorflow |
Contributor
Author
|
Confirmed that this unblocks #23193. Merging to unblock progress. |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
Update derivative name in `@differentiable` attribute when a derivative
function is set. This prevents linker errors.
Disable serialization for `@differentiable` attribute. It is unnecessary:
- Currently, type-checking sets the derivative in a `@differentiable` attribute
on the original function, which is serialized.
- If both `@differentiable` and `@differentiating` are serializable, using
`@differentiating` attribute causes an infinite loop occurs during
deserialization.
- In the future, `@differentiating` attribute will be lowered to SIL
differentiability witness tables, which will be serialized.
Unblocks swiftlang#23193: using `@differentiating` attribute in the stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update derivative name in
@differentiableattribute when a derivativefunction is set. This prevents linker errors.
Disable serialization for
@differentiableattribute. It is unnecessary:@differentiableattributeon the original function, which is serialized.
@differentiableand@differentiatingare serializable, using@differentiatingattribute causes an infinite loop occurs duringdeserialization.
@differentiatingattribute will be lowered to SILdifferentiability witness tables, which will be serialized.
Unblocks #23193: using
@differentiatingattribute in the stdlib.