Skip to content

Fix tracing leak from working with james. #24298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix tracing leak from working with james. #24298

merged 1 commit into from
Apr 26, 2019

Conversation

pschuh
Copy link
Contributor

@pschuh pschuh commented Apr 25, 2019

Two problems:

  • When returning a list of tensors, the CTensorHandles represent a reference. These need to be passed owning.
  • TFE_Ops will leak tensors if not freed.

@pschuh pschuh requested a review from bgogul April 25, 2019 23:57
@bgogul
Copy link
Contributor

bgogul commented Apr 25, 2019

Nice!

@pschuh
Copy link
Contributor Author

pschuh commented Apr 26, 2019

@swift-ci please test TensorFlow

@pschuh
Copy link
Contributor Author

pschuh commented Apr 26, 2019

@swift-ci please test TensorFlow gpu

rxwei
rxwei reviewed Apr 26, 2019
View reviewed changes
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

stdlib/public/TensorFlow/CompilerRuntime.swift
self.init(_owning: buffer)
}

init<C: Collection>(_owning input: C) where C.Element == CTensorHandle {
Copy link
Contributor

@rxwei rxwei Apr 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
init<C: Collection>(_owning input: C) where C.Element == CTensorHandle {
init<C : Collection>(_owning input: C) where C.Element == CTensorHandle {

(Random nit. No big deal.)

@pschuh
Copy link
Contributor Author

pschuh commented Apr 26, 2019

@swift-ci please test TensorFlow gpu

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Apr 26, 2019
@pschuh
Copy link
Contributor Author

pschuh commented Apr 26, 2019

GPU failure seems unrelated (tensor slicing)

@pschuh pschuh merged commit 57f8cf5 into swiftlang:tensorflow Apr 26, 2019
@eaplatanios eaplatanios mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rxwei rxwei rxwei left review comments

@bgogul bgogul bgogul approved these changes

Assignees

No one assigned

Labels

tensorflow This is for "tensorflow" branch PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pschuh @bgogul @rxwei @dan-zheng