[5.3] Reflection Library crash inspecting certain BoundGeneric types (#32983) #33008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang#32983) * Reflectio Library crash inspecting certain BoundGeneric types If the parent of a BoundGeneric type is not a NominalType (for example, if the Parent was an ObjCClass type) the `getDepth()` method would end up reading a Parent reference from uninitialized memory. The resulting garbage pointer would cause a crash in the tool that was using the reflection library (leaks, instruments, etc.) Of course, this does not always result in a crash, since the memory in question is frequently zeroed, resulting in a nil pointer that is safely detected. Resolves rdar://54173375 * Fix compile
|
@swift-ci Please test |
|
@swift-ci Please nominate |
mikeash
approved these changes
Jul 21, 2020
airspeedswift
approved these changes
Jul 21, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose merging #32983 to release/5.3
Original Description
If the parent of a BoundGeneric type is not a NominalType (for example, if the
Parent was an ObjCClass type) the
getDepth()method would end up reading aParent reference from uninitialized memory. The resulting garbage pointer
would cause a crash in the tool that was using the reflection library
(leaks, instruments, etc.)
Of course, this does not always result in a crash, since the memory in question
is frequently zeroed, resulting in a nil pointer that is safely detected.
Resolves rdar://54173375
CCC Info
Risk: Low. Adds a missing type check to avoid a crash.