[5.6][build] Allow cross-compiling build-script products for non-Darwin hosts too #40525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gottesmm, can we can get this in before the 5.6 release? |
…sts too To that end, move the --cross-compile-deps-path flag from build-script-impl to a publicly documented build-script flag and use it for build-script products' library dependencies too. Generate a SPM destination JSON file that can be used both for cross-compiling these build-script products and by users for their own Swift packages. Also, add a native_toolchain_path() method, that uses a prebuilt toolchain if available, and pass an install prefix in to swift-driver and sourcekit-lsp.
…e new host_install_destdir()
Member
Author
|
Closing since I was told only regressions or bugfixes wIll be accepted into the release branch after the release shipped, though I did submit this months prior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #36917
Explanation: This pull consists of a handful of
build-scriptchanges that enable cross-compiling later Pythonbuild-scriptproducts like SPM and swift-driver for non-Darwin hosts, just as is currently possible when cross-compiling the toolchain for macOS arm64, including generating a cross-compilation destination JSON config file to use with SPM for Android. Most of the pull is scoped to non-Darwin cross-compilation or specifically to Android, with the exception of some install prefix refactoring, because cross-compilation for non-Darwin hosts installs the toolchains separately under a directory named for each host.Scope: Since this is only build-related and mostly for non-Darwin cross-compilation, most is not even run on the CI, with the exception of the install prefix refactoring.
SR Issue: None
Risk: Almost none, only the simple install prefix changes even affect the normal host builds.
Testing: I've been using earlier versions of this pull for a while to cross-compile the toolchain for Android and recently added it to my Android CI so I can cross-compile SPM for Android with every trunk snapshot.
Reviewer: @gottesmm