[DNM] Parse /.../ regex literals (by re-lexing)
#41837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rintaro, still needs a way of delaying lexing diagnostics, but otherwise seems to work well |
|
@swift-ci please test source compatibility |
Try to lex regex literals with `/.../` delimiters.
Loudly error if `-enable-experimental-string-processing` is not used. This allows us to easily check for source compatibility conficts.
hamishknight
force-pushed
the
regular-grammar-in-parser
branch
from
b6934d3 to
20d41f9
Compare
|
@swift-ci please test |
|
This seems to be the way to go, continuing over on #41767. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41767, but implemented by re-lexing when we encounter a
/in the parser. Also implements the rule where a regex may not start with space, tab,), or,.